Initialize rabbits as down #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshcorbett
force-pushed
the
initialize-rabbits-as-down
branch
from
5be0ba2 to
f188ddb
Compare
jameshcorbett
force-pushed
the
initialize-rabbits-as-down
branch
from
f188ddb to
f0d7a6c
Compare
Problem: there is no way to set the status of a fluxion vertex in the testsuite. Add a helper script.
Problem: when Fluxion reads in the resource graph generated by dws2jgf, it initially marks all rabbits as up. This is undesirable because it may allocate down rabbits prematurely, before coral2_dws can mark rabbits as down. Initialize rabbits as down.
Problem: the testsuite expects rabbits to be initialized as up, but they are initialized as down, with a new 'status: 1' entry in the JGF. Update the expected JGF and test behavior.
jameshcorbett
force-pushed
the
initialize-rabbits-as-down
branch
from
f0d7a6c to
116bd86
Compare
|
The wabbits are down, you say? Did you try giving them carrwots? 🥕 🥕 |
|
It's worth everything @grondo ! Setting MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until Fluxion is updated to support a
statusparameter to the `FluxionResourcePoolV1 class.Edit: done.