libflux: add flux_watcher_is_active(3)
#6024
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There is no way to test if a flux_watcher_t is stopped or started. Add flux_watcher_is_active(3), which wraps ev_is_active(3).
Problem: There are no unit tests for flux_watcher_is_active(3). Ensure flux_watcher_is_active() returns false before a watcher is started, and true afterwards. Add a todo for periodic watchers, which do not seem to follow this rule.
Problem: flux_watcher_is_active(3) is not documented. Add it to flux_watcher_start.rst.
|
I tried doing this a long time ago (although tried to do it differently) #4173 I think you handled the gotchas, but just in case you wanted to review comments there |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6024 +/- ##
==========================================
- Coverage 83.29% 83.28% -0.01%
==========================================
Files 518 518
Lines 83514 83520 +6
==========================================
+ Hits 69560 69563 +3
- Misses 13954 13957 +3
|
|
I had forgotten that sorry! The use case that came up is that I was going to add per-job data to However, if this is still deemed more work than its worth, then I can close this one for now (I don't think it is worth it if we have to add a now method to flux_watcher_t that calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something I noticed that there was no libflux version of the
ev_is_active()call, which could come in handy to check if a watcher has been started.This simple PR just adds
flux_watcher_is_active(3), tests, and documentation.