content-sqlite: misc cleanup #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: unistd.h is included two times. Remove double include.
Problem: An out of date comment mentions code "above", but that code was likely refactored into a function some time ago. Remove the out of date comment.
Problem: In t0090-content-enospc.t a number of "clear and setup" things for the actual tests are done within their own tests. This leads to an excess number of tests. Move the "clear and setup" into each of the individual tests.
Problem: t0090-content-enospc.t used inconsistent tabs vs spaces. Tabify everything.
chu11
force-pushed
the
content_sqlite_cleanup
branch
from
66cde1c to
f3d59c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6220 +/- ##
=======================================
Coverage 83.31% 83.32%
=======================================
Files 521 521
Lines 85205 85205
=======================================
+ Hits 70986 70993 +7
+ Misses 14219 14212 -7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out from PR #6217, this is dinky stuff