WIP: kvs: support configuration of max transaction count #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
issue6572_kvs_transaction_max
branch
from
8868cd6 to
d245914
Compare
chu11
force-pushed
the
issue6572_kvs_transaction_max
branch
from
d245914 to
07ed829
Compare
|
re-pushed, removing all fence related parts of this PR, since KVS fence support is now gone |
Problem: A KVS denial of service is possible because there is no maximum on the number of operations a user can submit in a KVS transaction. For example, a KVS transaction with billions of KVS entries would lead to a severe degradation in KVS performance. Support a new KVS configuration "transaction-max-ops" that will reject KVS transaction with operations above a maximum count. The default maximum is 65536. Fixes flux-framework#6572
Problem: The new kvs transaction-max-ops configuration option is not documented. Add documentation to flux-config-kvs(5)
Problem: There is no coverage for the new kvs transaction-max-ops configuration. Add coverage in t1005-kvs-security.t.
chu11
force-pushed
the
issue6572_kvs_transaction_max
branch
from
07ed829 to
7b1939d
Compare
|
re-pushed, removing all the fence stuff that is no longer relevant b/c KVS fence support was removed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6581 +/- ##
==========================================
+ Coverage 79.45% 79.47% +0.01%
==========================================
Files 531 531
Lines 88282 88304 +22
==========================================
+ Hits 70145 70177 +32
+ Misses 18137 18127 -10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #6125, denial-of-service attacks could be made against the KVS by very very large KVS transactions.
Support two configurations for capping the number of transactions made by users. One for each individual transaction made by a caller and one for the combined total of operations from a fence.
For the time being, I made the default 64K for the transaction cap and 1M for the fence cap.
I made this WIP only b/c those defaults may be tweaked depending on what stats we get from the prior PR #6556. I would like to merge only after we gather a bit of data, although I'd be quite shocked if we have to adjust the defaults. Edit: Or alternately, if we'd like to just get the code in, we could default the max to LLONG_MAX and lower the default at a later time.
Only other thought is I decided to return the errno E2BIG if we went across a max cap boundary. It's possible there is a superior errno for this, I picked it b/c I thought "ehhh that's not bad".