plugin: set hwloc.xmlfile shell option #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: flux-pmix does not yet share hwloc with MPI, which forces MPI to go looking for it, sometimes at great cost to performance. For the time being, tell flux-core to share a hwloc xml file by setting the -o hwloc.xmlfile shell option. Later we will want to fix flux-framework#31 properly and drop this.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 78.13% 78.09% -0.04%
==========================================
Files 12 12
Lines 1413 1415 +2
==========================================
+ Hits 1104 1105 +1
- Misses 309 310 +1 ☔ View full report in Codecov by Sentry. |
grondo
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM! Might want to rerun checks now that flux-framework/flux-core#5721 is merged just in case.
|
Went ahead and restarted all the tests |
|
Thanks! I tested this manually with the flux-core |
garlick
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: flux-pmix does not yet share hwloc with MPI, which forces MPI to go looking for it, sometimes at great cost to performance.
For the time being, tell flux-core to share a hwloc xml file by setting the -o hwloc.xmlfile shell option.
Later we will want to fix #31 properly and drop this.