Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: set hwloc.xmlfile shell option #95

Merged
merged 1 commit into from
Feb 6, 2024
Merged

plugin: set hwloc.xmlfile shell option #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/shell/plugins/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,14 @@

shell_debug ("server is enabled");

/* flux-pmix does not yet share hwloc with MPI, which forces MPI to
* go looking for it, sometimes at great cost to performance.
* Until we can address flux-framework/flux-pmix#31 properly,
* tell flux-core to share a hwloc xml file instead.
*/
if (flux_shell_setopt_pack (shell, "hwloc", "{s:i}", "xmlfile", 1) < 0)
shell_warn ("unable to set Flux hwloc.xmlfile shell option");

Check warning on line 431 in src/shell/plugins/main.c

View check run for this annotation

Codecov / codecov/patch

src/shell/plugins/main.c#L431 

Added line #L431 was not covered by tests

if (flux_plugin_add_handler (p, "shell.init", px_init, NULL) < 0
|| flux_plugin_add_handler (p, "task.init", px_task_init, NULL) < 0) {
return -1;
Expand Down
Loading