Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate from focal to jammy, el8 #102

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

garlick
Copy link
Member

@garlick garlick commented Dec 10, 2024

Problem: focal CI builds are failing.

There seems to be a linkage problem with libjansson in the fluxrm/flux-core:focal image.

Move most focal builders to jammy.

There seems to be a problem with the configure script generated for ompi 2.x and 3.x in jammy:

checking for struct sockaddr_in... yes
checking if --with-cuda is set... not set (--with-cuda=) ./configure: line 13031: syntax error near unexpected token `)'
./configure: line 13031: `    )'

Move those builders to el8.

Tidy up builder descriptions.

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there an issue to be investigated in the flux-core focal image?

Also, should the src/test/docker/focal directory be removed by this PR?

@garlick
Copy link
Member Author

garlick commented Dec 10, 2024

I'll fix this to remove focal and also open a flux-core issue on the image

Problem: focal CI builds are failing.

Specifically, a flux-pmix test program that uses libflux-optparse.so
without other flux stuff cannot be linked due to unresolved jansson
symbols. Details are in flux-framework/flux-core#6496

Just move the focal builders to jammy to get CI working again here,
except the ompi 2.x and 3.x builds don't seem to work in jammy:

 checking for struct sockaddr_in... yes
 checking if --with-cuda is set... not set (--with-cuda=)
 ./configure: line 13031: syntax error near unexpected token `)'
 ./configure: line 13031: `    )'

so move those builders to el8 instead.

Tidy up builder descriptions.
Problem: ci only uses el8 and jammy docker images, but bionic,
focal, and el7 are still out there.

Remove them.
Update the default image in docker-run-checks.sh from focal to jammy.
@garlick
Copy link
Member Author

garlick commented Dec 10, 2024

CI seems confused by my retitling tests - I think it's waiting for the old test names to report in. I'll just manually merge this.
Thanks for the review.

@garlick garlick merged commit 5ff05f3 into flux-framework:main Dec 10, 2024
11 checks passed
@garlick garlick deleted the ci_jammy branch December 10, 2024 18:11
@grondo
Copy link
Contributor

grondo commented Dec 10, 2024

You may have to update branch protections. (Settings -> Branches -> Update branch protections)

@garlick
Copy link
Member Author

garlick commented Dec 10, 2024

Oh yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants