simplify interthread channel implementation #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the ABI changes in flux-core 0.70 to raw payload accessors actually need not impact this project since all interthread payloads are NUL terminated strings. The last parameter of flux_msg_get_payload() is changing from an int pointer to a size_t pointer. Just pass a NULL and avoid the entire issue as we don't need the size.
Problem: the interthread channel will be harder to maintain than necessary due to its use of the obscure flux_msglist pollfd/pollevents interface, an fd watcher, and a pthread mutex. Now that we have the interthread:// connector in flux-core, reimplement the interthread channel with back to back flux_t handles and a message watcher.
|
Thanks! Setting MWP. |
garlick
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the interthread channel will be harder to maintain than necessary due to its use of the obscure
flux_msglistpollfd/pollevents interface, an fd watcher, and a pthread mutex.Now that we have the interthread:// connector in flux-core, re-implement the interthread channel with back to back
flux_thandles and a "handle watcher".This will also allow the
flux_msglistpollfd/pollevents interface to be retired in flux-core as this is the last user.Also: avoid using the raw message interface so flux-pmix doesn't need to require flux-core > 0.69 for ABI compatibility.