testsuite: add pingpong test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: there is a lot of repetition in t/src/Makefile.am Put all the cppflags in $(AM_CPPFLAGS) so it applies by default to each target. Move all the libs to $(test_ldadd).
Problem: the testing in t1000-ompi-basic.t does not include MPI_Send() / MPI_Recv(), perhaps omitting a basic sanity check that would catch early problems. Add a simple MPI ping-pong program. Run it in 1n2p and 2n2p configs from t1000-ompi-basic.t.
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 10 10
Lines 1185 1185
=======================================
Hits 929 929
Misses 256 256 Continue to review full report at Codecov.
|
|
Thanks! |
garlick
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a little concerned that maybe something basic was not working because of #36 and wanted to take a smaller step between the "hello world" tests in
t1000-ompi-basic.tandt1001-osu-benchmarks.tso this PR adds a little test to the former that moves a bit of data between two ranks in 1np2 and 2np2 configs.Ultimately this didn't provide any useful clues to #36 but it still may not be a bad thing to do.