testsuite: put flux bin before ompi bin #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the test suite pushed the ompi bin directory in front of the flux bin directory, but when ompi is installed as a system package, this places /usr/bin in front of a possibly side installed flux-core path. This was noted to be the case on LLNL's lassen system. Place the flux path in front of the ompi path when setting up sharness test paths. This was first noted in flux-framework#85.
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 12 12
Lines 1382 1382
=======================================
Hits 1092 1092
Misses 290 290 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
garlick
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the test suite pushed the ompi bin directory in front of the flux bin directory, but when ompi is installed as a system package, this places /usr/bin in front of a possibly side installed flux-core path.
This was noted to be the case on LLNL's lassen system.
Place the flux path in front of the ompi path when setting up sharness test paths.
This was first noted in #85.