[WIP] Implement find in REAPI #1339
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
reviewed
Feb 14, 2025
| } else if (!(json_str = json_dumps (o, JSON_INDENT (0)))) { | ||
| json_decref (o); | ||
| o = NULL; | ||
| errno = ENOMEM; |
There was a problem hiding this comment.
This means no memory? In the context of parsing a string into json what is that saying?
| goto done; | ||
| if (!(out_buf_c = strdup (out_buf.c_str ()))) { | ||
| ctx->err_msg = __FUNCTION__; | ||
| ctx->err_msg += ": ERROR: can't allocate memory\n"; |
There was a problem hiding this comment.
Oh I think the answer is here. Could a find request really run out of memory? My impression is that the json string would be tiny.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
========================================
- Coverage 75.7% 75.6% -0.1%
========================================
Files 112 112
Lines 16410 16427 +17
========================================
Hits 12426 12426
- Misses 3984 4001 +17
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
findfunctionality to the REAPI. The primary client will be the Fluence and FluxQueue projects.The PR is WIP pending client testing and discussion about how to implement testing in Fluxion.