rfc42: rename flags to forwarding_flags #428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The exec request uses a field named "flags" to indicate what should be forwarded to the client. The use of the generic term "flags" can be ambiguous, as it could be easily confused for other "flags" used within subprocess code.
Rename the field to "forwarding_flags".
side note, this is mostly b/c in the future we would like to pass the actual "subprocess" flags to the remote server. So this is just mini-prep for that.
Obviously can debate the name. I considered "callback_flags" as well.