ssa: prevent unnecessary DeepCopy
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to retrieve the object, setting the GVK on the Unstructured is sufficient to be able to retrieve it from the cluster. This avoids deep-copying the object in full and then `nil` writing it again when it does not exist in the cluster. Which can potentially save quite some duplicate data when e.g. dealing with Custom Resource Definitions or other large object kinds. Signed-off-by: Hidde Beydals <[email protected]>
stefanprodan
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to retrieve the object, setting the GVK on the Unstructured is sufficient to be able to retrieve it from the cluster.
This avoids deep-copying the object in full and then
nilwriting it again when it does not exist in the cluster. Which can potentially save quite some duplicate data when e.g. dealing with Custom Resource Definitions or other large object kinds.