support puppeer-core too

fly-apps · Nov 25, 2023 · 4156013 · 4156013
1 parent 300e332
commit 4156013
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/gdf.js b/gdf.js
@@ -157,7 +157,8 @@ export class GDF {
 
   // Does this application use puppeteer?
   get puppeteer() {
-    return !!this.#pj.dependencies?.puppeteer
+    return !!this.#pj.dependencies?.puppeteer ||
+      !!this.#pj.dependencies?.['puppeteer-core']
   }
 
   // Packages needed for base stage
@@ -379,7 +380,7 @@ export class GDF {
     if (this.entrypoint) return false
 
     const version = parseInt(this.nodeVersion)
-    return (version >= 16) && ((version & 1) === 0)
+    return (version >= 16)
   }
 
   // List of package files needed to install

diff --git a/templates/Dockerfile.ejs b/templates/Dockerfile.ejs
@@ -6,7 +6,7 @@ ARG BUN_VERSION=<%= bunVersion %>
 FROM oven/bun:${BUN_VERSION} as base
 <% } else { -%>
 # Adjust NODE_VERSION as desired
-ARG NODE_VERSION=<%= distroless ? parseInt(nodeVersion) : nodeVersion %>
+ARG NODE_VERSION=<%= distroless ? (parseInt(nodeVersion) & ~1) : nodeVersion %>
 FROM node:${NODE_VERSION}-slim as <% if (distroless) { -%>build<% } else { %>base<% } %>
 <% } -%>