Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative background image #441

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Fix relative background image #441

merged 2 commits into from
Nov 9, 2024

Conversation

asolntsev
Copy link
Contributor

No description provided.

@asolntsev
#440 extract inlined html from test to a separate file
1dbc691
@asolntsev
#440 restore classes FSImageWriter and ImageRenderer
55aa49e 
class `FSImageWriter` is still needed because it's the only code that supports relative image urls in html.

P.S. This partially reverts commits 6d4569c and 061264c - seems
@asolntsev asolntsev self-assigned this Nov 9, 2024
@asolntsev asolntsev added this to the 9.11.0 milestone Nov 9, 2024
@asolntsev asolntsev mentioned this pull request Nov 9, 2024
Closed
@asolntsev asolntsev merged commit 44505f1 into main Nov 9, 2024
4 checks passed
@asolntsev asolntsev linked an issue Nov 9, 2024 that may be closed by this pull request
CSS background property with url to local image with relative path not getting rendered #440
Closed
@asolntsev asolntsev deleted the fix/relative-background-image branch November 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asolntsev asolntsev

Labels
None yet
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

CSS background property with url to local image with relative path not getting rendered
1 participant
@asolntsev