Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteidl] Support attribute access on promise - Add dataclass_type proto #4233

Closed
wants to merge 1 commit into from

Conversation

ByronHsu
Copy link
Contributor

@ByronHsu ByronHsu commented Oct 15, 2023

Tracking issue

#3864

Describe your changes

See flyteorg/flyteidl#439 (comment)

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@ByronHsu ByronHsu changed the title Add dataclass_type proto [flyteidl] Support attribute access on promise - Add dataclass_type proto Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2edc3bd) 59.52% compared to head (59eddc6) 78.41%.
Report is 2 commits behind head on master.

❗ Current head 59eddc6 differs from pull request most recent head 5cebcdd. Consider uploading reports for the commit 5cebcdd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4233       +/-   ##
===========================================
+ Coverage   59.52%   78.41%   +18.88%     
===========================================
  Files         639       18      -621     
  Lines       54611     1297    -53314     
===========================================
- Hits        32506     1017    -31489     
+ Misses      19543      217    -19326     
+ Partials     2562       63     -2499     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 639 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ByronHsu ByronHsu closed this Oct 17, 2023
@ByronHsu
Copy link
Contributor Author

Closed it because the change is duplicated in the flytepropeller PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant