Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master' into thomasjpfan/wandb…
Browse files Browse the repository at this point in the history
…_follow-up

Signed-off-by: Thomas J. Fan <[email protected]>
  • Loading branch information
thomasjpfan committed Jun 14, 2024
2 parents 8480849 + 4b2c06b commit 5a3f2a9
Show file tree
Hide file tree
Showing 107 changed files with 1,681 additions and 739 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pythonbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,8 @@ jobs:
cd plugins/${{ matrix.plugin-names }}
uv pip install --system .
if [ -f dev-requirements.in ]; then uv pip install --system -r dev-requirements.in; fi
uv pip install --system -U $GITHUB_WORKSPACE
# TODO: move to protobuf>=5. Github issue: https://github.com/flyteorg/flyte/issues/5448
uv pip install --system -U $GITHUB_WORKSPACE "protobuf<5"
uv pip freeze
- name: Test with coverage
run: |
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.2.2
rev: v0.4.7
hooks:
# Run the linter.
- id: ruff
Expand Down
2 changes: 0 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ ARG DOCKER_IMAGE
RUN apt-get update && apt-get install build-essential -y \
&& pip install uv \
&& uv pip install --system --no-cache-dir -U flytekit==$VERSION \
flytekitplugins-pod==$VERSION \
flytekitplugins-deck-standard==$VERSION \
scikit-learn \
&& apt-get clean autoclean \
&& apt-get autoremove --yes \
&& rm -rf /var/lib/{apt,dpkg,cache,log}/ \
Expand Down
7 changes: 6 additions & 1 deletion dev-requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ torch; python_version<'3.12'
# Once a solution is found, this should be updated to support Windows as well.
python-magic; (platform_system=='Darwin' or platform_system=='Linux')

types-protobuf
# Google released a new major version of the protobuf library and once that started being used in the ecosystem at large,
# including `googleapis-common-protos` we started seeing errors in CI, so let's constrain that for now.
# The issue to support protobuf 5 is being tracked in https://github.com/flyteorg/flyte/issues/5448.
protobuf<5
types-protobuf<5

types-croniter
types-decorator
types-mock
Expand Down
Loading

0 comments on commit 5a3f2a9

Please sign in to comment.