Fix: Fix deprecated numpy type and make numpy<2 explicit dependency (#…

…2483) * Replace deprecated np.string_ with np.bytes_ (alias) Signed-off-by: Fabio Grätz <[email protected]> * Make numpy an explicit dependency Signed-off-by: Fabio Grätz <[email protected]> * Pin numpy to <2 Signed-off-by: Fabio Grätz <[email protected]> --------- Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]>
flyteorg · Jun 17, 2024 · a902471 · a902471
1 parent 81c66d5
commit a902471
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/flytekit/types/schema/types.py b/flytekit/types/schema/types.py
@@ -334,7 +334,7 @@ class FlyteSchemaTransformer(TypeTransformer[FlyteSchema]):
         datetime.datetime: SchemaType.SchemaColumn.SchemaColumnType.DATETIME,
         _np.timedelta64: SchemaType.SchemaColumn.SchemaColumnType.DURATION,
         datetime.timedelta: SchemaType.SchemaColumn.SchemaColumnType.DURATION,
-        _np.string_: SchemaType.SchemaColumn.SchemaColumnType.STRING,
+        _np.bytes_: SchemaType.SchemaColumn.SchemaColumnType.STRING,
         _np.str_: SchemaType.SchemaColumn.SchemaColumnType.STRING,
         _np.object_: SchemaType.SchemaColumn.SchemaColumnType.STRING,
         str: SchemaType.SchemaColumn.SchemaColumnType.STRING,

diff --git a/flytekit/types/structured/structured_dataset.py b/flytekit/types/structured/structured_dataset.py
@@ -340,7 +340,7 @@ def get_supported_types():
         _datetime.datetime: type_models.LiteralType(simple=type_models.SimpleType.DATETIME),
         _np.timedelta64: type_models.LiteralType(simple=type_models.SimpleType.DURATION),
         _datetime.timedelta: type_models.LiteralType(simple=type_models.SimpleType.DURATION),
-        _np.string_: type_models.LiteralType(simple=type_models.SimpleType.STRING),
+        _np.bytes_: type_models.LiteralType(simple=type_models.SimpleType.STRING),
         _np.str_: type_models.LiteralType(simple=type_models.SimpleType.STRING),
         _np.object_: type_models.LiteralType(simple=type_models.SimpleType.STRING),
         str: type_models.LiteralType(simple=type_models.SimpleType.STRING),

diff --git a/pyproject.toml b/pyproject.toml
@@ -37,6 +37,7 @@ dependencies = [
     "marshmallow-enum",
     "marshmallow-jsonschema>=0.12.0",
     "mashumaro>=3.11",
+    "numpy<2",
     "protobuf!=4.25.0",
     "pyarrow",
     "pygments",