revert minor changes

flyteorg · May 21, 2024 · c82b2e5 · c82b2e5
1 parent ccfd564
commit c82b2e5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/flytekit/clis/sdk_in_container/run.py b/flytekit/clis/sdk_in_container/run.py
@@ -250,7 +250,7 @@ class RunLevelParams(PyFlyteParams):
     )
     cluster_pool: str = make_click_option_field(
         click.Option(
-            param_decls=["--cluster-pool"],
+            param_decls=["--cluster-pool", "cluster_pool"],
             required=False,
             type=str,
             default="",

diff --git a/flytekit/remote/remote.py b/flytekit/remote/remote.py
@@ -1113,7 +1113,7 @@ def _execute(
         :param envs: Environment variables to set for the execution.
         :param tags: Tags to set for the execution.
         :param cluster_pool: Specify cluster pool on which newly created execution should be placed.
-        :param execution_cluster_label: Specify cluster on which newly created execution should be placed.
+        :param execution_cluster_label: Specify label of cluster(s) on which newly created execution should be placed.
         :returns: :class:`~flytekit.remote.workflow_execution.FlyteWorkflowExecution`
         """
         if execution_name is not None and execution_name_prefix is not None:
@@ -1294,7 +1294,7 @@ def execute(
         :param envs: Environment variables to be set for the execution.
         :param tags: Tags to be set for the execution.
         :param cluster_pool: Specify cluster pool on which newly created execution should be placed.
-        :param execution_cluster_label: Specify cluster on which newly created execution should be placed.
+        :param execution_cluster_label: Specify label of cluster(s) on which newly created execution should be placed.
 
         .. note:
 
@@ -1713,7 +1713,7 @@ def execute_local_task(
         :param envs: Environment variables to set for the execution.
         :param tags: Tags to set for the execution.
         :param cluster_pool: Specify cluster pool on which newly created execution should be placed.
-        :param execution_cluster_label: Specify cluster on which newly created execution should be placed.
+        :param execution_cluster_label: Specify label of cluster(s) on which newly created execution should be placed.
         :return: FlyteWorkflowExecution object.
         """
         resolved_identifiers = self._resolve_identifier_kwargs(entity, project, domain, name, version)
@@ -1868,7 +1868,7 @@ def execute_local_launch_plan(
         :param envs: Environment variables to be passed into the execution.
         :param tags: Tags to be passed into the execution.
         :param cluster_pool: Specify cluster pool on which newly created execution should be placed.
-        :param execution_cluster_label: Specify cluster on which newly created execution should be placed.
+        :param execution_cluster_label: Specify label of cluster(s) on which newly created execution should be placed.
         :return: FlyteWorkflowExecution object
         """
         resolved_identifiers = self._resolve_identifier_kwargs(entity, project, domain, name, version)

diff --git a/tests/flytekit/integration/remote/test_remote.py b/tests/flytekit/integration/remote/test_remote.py
@@ -214,14 +214,12 @@ def test_execute_python_task(register):
         envs={"foo": "bar"},
         tags=["flyte"],
         cluster_pool="gpu",
-        execution_cluster_label="label",
     )
     assert execution.outputs["t1_int_output"] == 12
     assert execution.outputs["c"] == "world"
     assert execution.spec.envs.envs == {"foo": "bar"}
     assert execution.spec.tags == ["flyte"]
     assert execution.spec.cluster_assignment.cluster_pool == "gpu"
-    assert execution.spec.execution_cluster_label.value == "label"
 
 
 def test_execute_python_workflow_and_launch_plan(register):