Enable string conversion for Scalar objects that contain a schema
#2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redartera
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: redartera <[email protected]>
redartera
force-pushed
the
scalar-to-string-schema
branch
from
e85f05a
to
72a64d4
Compare
pingsutw
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
@redartera Thanks. Could you use the structured dataset? We have deprecated it for a while.
|
Congrats on merging your first pull request! 🎉 |
@pingsutw I don't use Looking at the |
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: redartera <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: redartera <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If attempting to create a string representation of a literal whose scalar contains a
schema(e.g. pandera DataFrames), an "Unknown scalar type"ValueErroris raised.It is often nice to just print out the outputs of a workflow execution, but that's currently not possible if a pandera-typed DataFrame is one of them.
What changes were proposed in this pull request?
We simply return the schema's URI, similarly to how
structured_datasetis handled.How was this patch tested?
I expanded on the existing unit test