Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include remote file paths with special characters #2478

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

RRK1000
Copy link
Contributor

@RRK1000 RRK1000 commented Jun 13, 2024

Tracking issue

Closes flyteorg/flyte#5445

Why are the changes needed?

Currently, if the input argument contains a FlyteFile whose name contains special characters, the execution fails. This PR fixes this bug, and enables filenames with special characters.

What changes were proposed in this pull request?

The PR introduces the unquote function from the urllib.parse library, that replaces the percent encoded special characters with their single character equivalent on the uri param of the Literal class.

How was this patch tested?

This was tested by replicating the steps mentioned in the issue flyteorg/flyte#5445

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

welcome bot commented Jun 13, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (63f190e) to head (92e9059).
Report is 4 commits behind head on master.

Current head 92e9059 differs from pull request most recent head fd9053c

Please upload reports for the commit fd9053c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2478       +/-   ##
===========================================
+ Coverage   41.82%   76.16%   +34.33%     
===========================================
  Files         182      190        +8     
  Lines       18505    18785      +280     
  Branches     3856     3644      -212     
===========================================
+ Hits         7740    14307     +6567     
+ Misses      10637     3850     -6787     
- Partials      128      628      +500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rishi Ravikumar <[email protected]>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! could you run make fmt & make lint to resolve the lint error

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pingsutw pingsutw merged commit 81c66d5 into flyteorg:master Jun 16, 2024
45 of 46 checks passed
Copy link

welcome bot commented Jun 16, 2024

Congrats on merging your first pull request! 🎉

bgedik pushed a commit to bgedik/flytekit that referenced this pull request Jul 3, 2024
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Local FlyteFile whose name contains spaces fail in remote execution with "File Not Found" error
2 participants