Fix overriding of loader_args task resolver in papermill plugin #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
changed the title
pingsutw
approved these changes
Aug 8, 2024
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
…eorg#2660) * Add repro test case Signed-off-by: Eduardo Apolinario <[email protected]> * Restore loader_args in papermill plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Add unit tests Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: mao3267 <[email protected]>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
…eorg#2660) * Add repro test case Signed-off-by: Eduardo Apolinario <[email protected]> * Restore loader_args in papermill plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Add unit tests Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
…eorg#2660) * Add repro test case Signed-off-by: Eduardo Apolinario <[email protected]> * Restore loader_args in papermill plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Add unit tests Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Mecoli1219 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In #1859 (which was released in flytekitplugins-papermill 1.10.0) we ended up overriding the task resolver's
loader_argsmethod in order to generate the correctNotebookTaskcontainer arguments. However we never restored that function to its original value, which has the side effect that in the case of shared task resolvers (e.g. thedefault_task_resolverused for regular tasks) we end up reusing the lastNotebookTaskregistered as the task name.What changes were proposed in this pull request?
This PR restores the loader_args in papermill plugin's
get_containerandget_k8s_pod.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link