Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UV install to after the ENV is set #2681

Merged

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

On master, the UV install command runs before the ENV is set.

What changes were proposed in this pull request?

This PR moves ENV before the UV command runs.

How was this patch tested?

I ran pytest with _FLYTEKIT_TEST_DEFAULT_BUILDER=1.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.06%. Comparing base (69445ff) to head (31ef8a1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2681      +/-   ##
==========================================
- Coverage   79.24%   73.06%   -6.18%     
==========================================
  Files         196      207      +11     
  Lines       19785    19921     +136     
  Branches     4008     4006       -2     
==========================================
- Hits        15678    14555    -1123     
- Misses       3407     4692    +1285     
+ Partials      700      674      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasjpfan thomasjpfan merged commit 1cd8160 into flyteorg:master Aug 14, 2024
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants