-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dest_dir into pythonpath before loading modules #2692
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a77525d
add dynamic_dest_dir into pythonpath before loading modules
arbaobao ed5cc27
Add dest_dir to pythonpath before creating subprocess
arbaobao 898cc66
Merge branch 'flyteorg:master' into add_dest_dir
arbaobao b62938d
improve code
arbaobao 05ea7f8
resolve dest_dir
arbaobao 1982940
add dest_dir to test
arbaobao 1fd11e5
Merge branch 'flyteorg:master' into add_dest_dir
arbaobao 7a90b32
Merge branch 'flyteorg:master' into add_dest_dir
arbaobao 66ad221
consider ~ is in path
arbaobao 29b1c7b
Merge branch 'add_dest_dir' of github.com:arbaobao/flytekit into add_…
arbaobao 5557af7
test
arbaobao 65ac03f
consider if ~ is in dest_dir
arbaobao 27583b0
Merge branch 'flyteorg:master' into add_dest_dir
arbaobao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new process may have a different
sys.path
that is not connected to the current process.I think it's okay to just check for
dest_dir is not None
.