Fix: Make flyte-iap catch when trying to generate token for service account from user credentials #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m user credentials Signed-off-by: Fabio Grätz <[email protected]>
fg91
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
fg91
changed the title
pingsutw
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli
flyte-iapprovided byflytekitplugins-identity-aware-proxycan be used byflytekitandflytectlas a so-calledproxyCommandto generate a token sent asproxy-authorizationheader to a flyteadmin protected by GCP Identity Aware Proxy. See original issue.We currently don't catch when users try to generate a token for a service account when logged in with their user account.
This PR catches this and raises an actionable error.