Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes to 1.14.3 #3019

Open
wants to merge 5 commits into
base: release-v1.14
Choose a base branch
from

Conversation

pingsutw and others added 5 commits December 23, 2024 15:08
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
* add support for toggling data mode for array node

Signed-off-by: Paul Dittamo <[email protected]>

* clean up

Signed-off-by: Paul Dittamo <[email protected]>

* clean up

Signed-off-by: Paul Dittamo <[email protected]>

* cleanup

Signed-off-by: Paul Dittamo <[email protected]>

* Bump flyteidl lower-bound to 1.14.1

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add import of FlyteLaunchPlan back

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (0b4a60a) to head (1e1e281).
Report is 3 commits behind head on release-v1.14.

Files with missing lines Patch % Lines
flytekit/core/array_node.py 57.14% 4 Missing and 2 partials ⚠️
flytekit/interactive/vscode_lib/decorator.py 0.00% 3 Missing ⚠️
flytekit/extend/backend/agent_service.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0b4a60a) and HEAD (1e1e281). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0b4a60a) HEAD (1e1e281)
5 4
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.14    #3019      +/-   ##
=================================================
- Coverage          81.40%   76.18%   -5.22%     
=================================================
  Files                200      200              
  Lines              21012    21025      +13     
  Branches            2707     2704       -3     
=================================================
- Hits               17104    16018    -1086     
- Misses              3151     4227    +1076     
- Partials             757      780      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants