Remove hardcoded ref to docs #3068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #2c5238Actionable Suggestions - 0Review Details
AI Code Review powered by |
thomasjpfan
previously approved these changes
Jan 18, 2025
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Jan 25, 2025
Code Review Agent Run #c8672aActionable Suggestions - 0Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
On
pyflyte initandunion initthe message reporting success includes a hardcoded reference to a page in the Flyte docs.The location of this page could easily change, and for union the reference is entirely incorrect.
It is better to simply remove the URL completely. It adds very little utility.
What changes were proposed in this pull request?
Change to text displayed on CLI command success
Summary by Bito
Modified and simplified Flyte CLI success message for project initialization commands by removing hardcoded documentation URL. The change streamlines the success message to only show project directory name, enhancing maintainability and preventing potential issues with broken documentation links.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1