Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Implement Spark pod template tolerations #411

Closed
wants to merge 1 commit into from

Conversation

andrewwdye
Copy link
Contributor

TL;DR

Populate driver and executor tolerations from optional pod templates. This is an initial step narrowly focused on pod tolerations, to be followed by a more generic solution that handles all pod template functionality.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This change builds on optional Spark pod template changes added in flyteorg/flyteidl#450. For now appends tolerations from the driver and executor pod templates, if any, to the defaults used to build the SparkApplicationSpec. A follow up PR will refactor the Spark plugin and pod_helper.go to reuse ToK8sPodSpec in order to consume other aspect of pod templates, as is done for other plugins.

Tracking Issue

flyteorg/flyte#4105

@eapolinario
Copy link
Contributor

eapolinario commented Oct 3, 2023

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to . Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

edit: Re-opening these PRs as the automation failed.

@eapolinario eapolinario closed this Oct 3, 2023
@eapolinario eapolinario reopened this Oct 3, 2023
@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4130. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants