attribute access documentation #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troychiu
force-pushed
the
attribute-access-on-promises
branch
from
b1cbf35
to
ac0a009
Compare
|
Thanks for the awesome doc! It lists out all the use cases and caveats of attribute access in an easy-to-understand way. I am wondering if moving this to "Advanced composition" makes more sense. The current content of "basic type and I/O" is more about flyte type. This is more like you want to access the promise attribute when composing a workflow. I will let @wild-endeavor and @cosmicBboy to decide |
|
This pr has been pending for a while. @wild-endeavor @cosmicBboy could you help taking a look? also, @troychiu could you fix the ci errors? |
troychiu
force-pushed
the
attribute-access-on-promises
branch
from
5b14b25
to
780ba80
Compare
cosmicBboy
previously approved these changes
Nov 27, 2023
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
troychiu
force-pushed
the
attribute-access-on-promises
branch
from
fd0b59c
to
6be7bf7
Compare
neverett
requested changes
Nov 29, 2023
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
examples/data_types_and_io/data_types_and_io/attribute_access.py
Outdated
Show resolved
Hide resolved
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
|
Thank you @neverett and @cosmicBboy. I have resolved all suggestions and the CI error! |
neverett
approved these changes
Nov 30, 2023
cosmicBboy
approved these changes
Nov 30, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the documentation for attribute access on promises.
Issue: flyteorg/flyte#4409
Associated PR: flyteorg/flyteidl#439