-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest main tries to link f(un)lockfile even with FMT_OS OFF #4189
Comments
Looks like there was a similar issue previously (#4054) that got fixed and has now regressed. Perhaps the detection mechanism broke. |
It is also possible that something broke in the open-sources SDKs but it is a bit unusual that it would change in 3 of them: Version 92227c7 still builds and links OK |
Bisecting.. |
439b6d7 is the first bad commit
|
Looks like these platforms declare but do not define Worked around with: if(NINTENDO_3DS OR NINTENDO_SWITCH OR VITA)
target_compile_definitions(fmt PUBLIC FMT_USE_FALLBACK_FILE=1)
endif() |
I've tried updating libfmt to the latest git (diasurgical/devilutionX#7457) and it appears the current version attempts to link f(un)lockfile even with
set(FMT_OS OFF)
.https://github.com/diasurgical/devilutionX/actions/runs/11191322109/job/31114078447?pr=7457
The text was updated successfully, but these errors were encountered: