Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libfmt #7457

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Update libfmt #7457

merged 4 commits into from
Oct 5, 2024

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Oct 5, 2024 •
edited
Loading

@glebm glebm enabled auto-merge (rebase) October 5, 2024 07:04
@glebm glebm mentioned this pull request Oct 5, 2024
Closed
@azihassan
Copy link

azihassan commented Oct 5, 2024 •
edited
Loading

LGTM (other than the linking issue)

Thanks I did something similar in azihassan#9, I'll update the commit hash in that PR and clean it up to make it easier to bring the fork up to date ki

@glebm
Copy link
Collaborator Author

glebm commented Oct 5, 2024 •
edited
Loading

A few builds are failing with the latest libfmt (fmtlib/fmt#4189) so this isn't ready to be merged yet

@azihassan
Copy link

Ah yes, I just noticed. It's a long shot but could the railing SDKs be enabling FMT_MODULE? It looks like it's overriding FMT_OS in the latest cmake

@glebm
Set FMT_USE_FALLBACK_FILE=1 on some platforms
04ecccb 
These platforms incorrectly declare but do not define `f(un)lockfile`.
`FMT_USE_FALLBACK_FILE=1` prevents libfmt from trying to use these
functions.
@glebm
Copy link
Collaborator Author

glebm commented Oct 5, 2024 •
edited
Loading

It wasn't quite that. Should be good to go now!
(details in fmtlib/fmt#4189)

@glebm
Copy link
Collaborator Author

glebm commented Oct 5, 2024

This is where you may want to add Dreamcast:

if(TARGET_PLATFORM STREQUAL "rg99")
  target_compile_definitions(fmt PUBLIC FMT_BUILTIN_TYPES=0)
endif()

This disables precompilation of formatters for built-in types (such as double).

@AJenbo AJenbo disabled auto-merge October 5, 2024 10:20
@AJenbo AJenbo merged commit 63fd721 into diasurgical:master Oct 5, 2024
22 of 23 checks passed
@glebm glebm deleted the upd-libfmt branch October 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJenbo AJenbo AJenbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glebm @azihassan @AJenbo