-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libfmt #7457
Update libfmt #7457
Conversation
LGTM (other than the linking issue) Thanks I did something similar in azihassan#9, I'll update the commit hash in that PR and clean it up to make it easier to bring the fork up to date ki |
A few builds are failing with the latest libfmt (fmtlib/fmt#4189) so this isn't ready to be merged yet |
Ah yes, I just noticed. It's a long shot but could the railing SDKs be enabling FMT_MODULE? It looks like it's overriding FMT_OS in the latest cmake |
These platforms incorrectly declare but do not define `f(un)lockfile`. `FMT_USE_FALLBACK_FILE=1` prevents libfmt from trying to use these functions.
It wasn't quite that. Should be good to go now! |
This is where you may want to add Dreamcast: if(TARGET_PLATFORM STREQUAL "rg99")
target_compile_definitions(fmt PUBLIC FMT_BUILTIN_TYPES=0)
endif() This disables precompilation of formatters for built-in types (such as |
/cc @azihassan