Add log statements for every request #65

srpurani · 2020-03-04T19:22:50Z

FDK should log before and after a call completes. This is achieved by adding log lines to handleRequest.
The boilerplate code in the init image should have a log message printed to serve as an example.

* FDK should log before and after a call completes. This is achieved by adding log lines to handleRequest. * The boilerplate code in the init image should have a log message printed to serve as an example.

mrc · 2020-03-06T21:39:24Z

handler.go

@@ -39,6 +39,7 @@ func (h *httpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	defer cancel()

 	logFrameHeader(r)
+	log.Println("Request started")


I don't think log.Println flushes, is this a problem? (I can see it might be, if the customer's trying to figure out why there code isn't running, but maybe it's out of scope for this change?)

It appears to flush, I think the problem was in Python fdk iirc.

Add log statements for every request

bbe16b4

* FDK should log before and after a call completes. This is achieved by adding log lines to handleRequest. * The boilerplate code in the init image should have a log message printed to serve as an example.

srpurani requested review from mrc, saintarian, riconnon and sachin-pikle March 4, 2020 19:23

saintarian approved these changes Mar 5, 2020

View reviewed changes

mrc reviewed Mar 6, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add log statements for every request #65

Add log statements for every request #65

srpurani commented Mar 4, 2020

mrc Mar 6, 2020

srpurani Mar 9, 2020

Add log statements for every request #65

Are you sure you want to change the base?

Add log statements for every request #65

Conversation

srpurani commented Mar 4, 2020

mrc Mar 6, 2020

Choose a reason for hiding this comment

srpurani Mar 9, 2020

Choose a reason for hiding this comment