-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add wallet app tutorial #421
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
buildscript { | ||
ext.kotlin_version = '1.7.10' | ||
ext.kotlin_version = '2.0.21' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Kotlin 2.0.21 is incompatible with Android Gradle Plugin 7.3.0 The verification confirms that the Android Gradle Plugin version 7.3.0 is being used in the project. Kotlin 2.0.x is not compatible with this AGP version, as it requires a more recent version of the Android Gradle Plugin. Additionally, other examples in the codebase are using Kotlin 1.7.10, which indicates this is the established version across the project. Recommendations:
🔗 Analysis chainConsider using a more stable Kotlin version for the tutorial The update to Kotlin 2.0.21 introduces potential risks:
Consider using the latest stable 1.x version (e.g., 1.9.22) which is more widely tested with Android tooling. Let's verify the compatibility with Android Gradle Plugin: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check Kotlin versions recommended for Android Gradle Plugin 7.3.0
# Search for any Kotlin version recommendations in the Android documentation
rg --type md "Kotlin.*version.*7\.3\.0"
# Look for any version constraints in build files
rg "kotlin.*version.*7\.3\.0"
Length of output: 73 Script: #!/bin/bash
# Let's check the current Android Gradle Plugin version and other dependencies
# Check build.gradle files for Android Gradle Plugin version
rg "com\.android\.tools\.build:gradle" -A 2
# Check other Kotlin-related dependencies
rg "org\.jetbrains\.kotlin" -A 2
# Look for any other build configuration that might give context
rg "compileSdk|minSdk|targetSdk|buildToolsVersion"
Length of output: 4246 |
||
repositories { | ||
google() | ||
mavenCentral() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add await to WalletKit initialization
The WalletKit initialization in the tutorial is missing the
await
keyword, unlike the actual implementation in main.dart.📝 Committable suggestion