Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inventory-audit): Implement item audit endpoint #194

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Feb 11, 2025

Purpose

Implement item audit endpoint
MODAUD-212

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.
    • Check logging

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@viacheslavkol viacheslavkol self-assigned this Feb 11, 2025
@viacheslavkol viacheslavkol marked this pull request as ready for review February 11, 2025 16:26
@viacheslavkol viacheslavkol requested review from a team, psmagin, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team February 11, 2025 16:26
# Conflicts:
#	mod-audit-server/src/test/java/org/folio/rest/impl/InventoryAuditApiTest.java
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@viacheslavkol viacheslavkol merged commit 8e15b52 into master Feb 12, 2025
7 of 8 checks passed
@viacheslavkol viacheslavkol deleted the MODAUD-212 branch February 12, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants