Skip to content

Commit

Permalink
MODDCB-124 Fix formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
OleksandrVidinieiev committed Nov 4, 2024
1 parent 0cafe09 commit 77722bc
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public class EcsRequestTransactionsApiController implements EcsRequestTransactio
@Override
public ResponseEntity<TransactionStatusResponse> createEcsRequestTransactions(
String ecsRequestTransactionId, DcbTransaction dcbTransaction) {

log.info("createEcsRequestTransactions:: creating ECS Request Transaction {} with ID {}",
dcbTransaction, ecsRequestTransactionId);
TransactionStatusResponse transactionStatusResponse;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public class EcsRequestTransactionsServiceImpl implements EcsRequestTransactions
@Override
public TransactionStatusResponse createEcsRequestTransactions(String ecsRequestTransactionsId,
DcbTransaction dcbTransaction) {

log.info("createEcsRequestTransactions:: creating new transaction request for role {} ",
dcbTransaction.getRole());
checkEcsRequestTransactionExistsAndThrow(ecsRequestTransactionsId);
Expand All @@ -60,7 +61,7 @@ public TransactionStatusResponse createEcsRequestTransactions(String ecsRequestT
.patron(dcbTransaction.getPatron())
.build();
} else {
throw new IllegalArgumentException("Unable to create ecs transaction as could not find open request");
throw new IllegalArgumentException("Unable to create ECS transaction as could not find open request");
}
}

Expand All @@ -74,6 +75,7 @@ private void checkEcsRequestTransactionExistsAndThrow(String dcbTransactionId) {

private void createLenderEcsRequestTransactions(String ecsRequestTransactionsId,
DcbTransaction dcbTransaction, CirculationRequest circulationRequest) {

dcbTransaction.setItem(DcbItem.builder()
.id(String.valueOf(circulationRequest.getItemId()))
.barcode(circulationRequest.getItem().getBarcode())
Expand All @@ -91,6 +93,7 @@ private void createLenderEcsRequestTransactions(String ecsRequestTransactionsId,

private void createBorrowerEcsRequestTransactions(String ecsRequestTransactionsId,
DcbTransaction dcbTransaction, CirculationRequest circulationRequest) {

var itemVirtual = dcbTransaction.getItem();
if (itemVirtual == null) {
throw new IllegalArgumentException("Item is required for borrower transaction");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -602,11 +602,11 @@ void lenderTransactionStatusUpdateFromCreatedToOpen() throws Exception {
systemUserScopedExecutionService.executeAsyncSystemUserScoped(TENANT, () -> transactionRepository.save(dcbTransaction));

this.mockMvc.perform(
put("/transactions/" + transactionID + "/status")
.content(asJsonString(createTransactionStatus(TransactionStatus.StatusEnum.OPEN)))
.headers(defaultHeaders())
.contentType(MediaType.APPLICATION_JSON)
.accept(MediaType.APPLICATION_JSON))
put("/transactions/" + transactionID + "/status")
.content(asJsonString(createTransactionStatus(TransactionStatus.StatusEnum.OPEN)))
.headers(defaultHeaders())
.contentType(MediaType.APPLICATION_JSON)
.accept(MediaType.APPLICATION_JSON))
.andExpect(status().isOk())
.andExpect(jsonPath("$.status").value("OPEN"));
}
Expand Down

0 comments on commit 77722bc

Please sign in to comment.