Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODORDERS-1237]. Create a new API and wrapper model for Claiming with an Organization Id #466

Merged
merged 12 commits into from
Jan 22, 2025
Merged

[MODORDERS-1237]. Create a new API and wrapper model for Claiming with an Organization Id #466

merged 12 commits into from
Jan 22, 2025

Conversation

BKadirkhodjaev
Copy link
Contributor

@BKadirkhodjaev BKadirkhodjaev commented Jan 20, 2025 •
edited
Loading

Purpose

Approach

  • Add new DB view for wrapping Pieces
  • Add PurchaseOrder and PoLine objects to this DB view to aid filtration and sorting on the UI
  • Add a new RAML-based API that handles 2 endpoints: Get all wrapper/wrapped Pieces and Get wrapper Piece by id
  • Test new endpoints with RestAssured-based integration tests

@BKadirkhodjaev BKadirkhodjaev marked this pull request as ready for review January 21, 2025 08:24
@BKadirkhodjaev BKadirkhodjaev requested a review from a team January 21, 2025 08:24
SerhiiNosko
SerhiiNosko reviewed Jan 22, 2025
View reviewed changes
src/main/resources/templates/db_scripts/views/wrapper_pieces_view.sql
from ${myuniversity}_${mymodule}.pieces t
join ${myuniversity}_${mymodule}.po_line c on c.id = t.polineid
join ${myuniversity}_${mymodule}.titles d on d.id = t.titleId
join ${myuniversity}_${mymodule}.purchase_order e on e.id = c.purchaseorderid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p - pieces, pol - pol line, t - titles, po - order
Can consider this naming

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BKadirkhodjaev BKadirkhodjaev merged commit 4bbbe2b into master Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizbekxm azizbekxm azizbekxm approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BKadirkhodjaev @SerhiiNosko @azizbekxm