[MODPUBSUB-295] - Review and cleanup Module Descriptor for mod-pubsub (…

…#281) * [MODPUBSUB-295] - Review and cleanup Module Descriptor for mod-pubsub * [MODPUBSUB-295] - Review and cleanup Module Descriptor for mod-pubsub * [MODPUBSUB-295] - Review and cleanup Module Descriptor for mod-pubsub * [MODPUBSUB-295] - Review and cleanup Module Descriptor for mod-pubsub
folio-org · Nov 22, 2024 · d6c6be4 · d6c6be4
1 parent 9949586
commit d6c6be4
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 5 deletions.
diff --git a/descriptors/ModuleDescriptor-template.json b/descriptors/ModuleDescriptor-template.json
@@ -26,7 +26,7 @@
           ],
           "pathPattern": "/pubsub/event-types",
           "permissionsRequired": [
-            "pubsub.event-types.get"
+            "pubsub.event-types.collection.get"
           ]
         },
         {
@@ -44,7 +44,7 @@
           ],
           "pathPattern": "/pubsub/event-types/{eventTypeName}",
           "permissionsRequired": [
-            "pubsub.event-types.get"
+            "pubsub.event-types.item.get"
           ]
         },
         {
@@ -220,9 +220,15 @@
   ],
   "permissionSets": [
     {
-      "permissionName": "pubsub.event-types.get",
+      "permissionName": "pubsub.event-types.collection.get",
+      "displayName": "PubSub - get Event Descriptor collection",
+      "description": "Get Event Descriptor collection"
+    },
+    {
+      "permissionName": "pubsub.event-types.item.get",
       "displayName": "PubSub - get Event Descriptor",
-      "description": "Get Event Descriptor"
+      "description": "Get Event Descriptor",
+      "replaces": ["pubsub.event-types.get"]
     },
     {
       "permissionName": "pubsub.event-types.post",

diff --git a/mod-pubsub-client/pom.xml b/mod-pubsub-client/pom.xml
@@ -179,6 +179,16 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.folio</groupId>
+        <artifactId>folio-module-descriptor-validator</artifactId>
+        <version>${folio-module-descriptor-validator.version}</version>
+        <executions>
+          <execution>
+            <phase/>  <!-- skip execution, run in parent only -->
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 

diff --git a/mod-pubsub-server/pom.xml b/mod-pubsub-server/pom.xml
@@ -390,6 +390,16 @@
         </configuration>
       </plugin>
 
+      <plugin>
+        <groupId>org.folio</groupId>
+        <artifactId>folio-module-descriptor-validator</artifactId>
+        <version>${folio-module-descriptor-validator.version}</version>
+        <executions>
+          <execution>
+            <phase/>  <!-- skip execution, run in parent only -->
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 

diff --git a/pom.xml b/pom.xml
@@ -28,6 +28,9 @@
     <main.basedir>${project.basedir}</main.basedir>
     <ramlfiles_path>${basedir}/ramls</ramlfiles_path>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+    <!--Folio dependencies properties-->
+    <folio-module-descriptor-validator.version>1.0.1</folio-module-descriptor-validator.version>
   </properties>
 
   <dependencyManagement>
@@ -246,7 +249,18 @@
           </execution>
         </executions>
       </plugin>
-
+      <plugin>
+        <groupId>org.folio</groupId>
+        <artifactId>folio-module-descriptor-validator</artifactId>
+        <version>${folio-module-descriptor-validator.version}</version>
+        <executions>
+          <execution>
+            <goals>
+              <goal>validate</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>