OKAPI-1207: LoginClient/RefreshClient: No stacktrace, compress JSON #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JSON https://folio-org.atlassian.net/browse/OKAPI-1207 okapi-common' LoginClient and RefreshClient fail if user is blocked or password is wrong. It causes a log entry with stacktrace and multi-line JSON body. The stacktrace is useless because it only shows Netty and Vert.x interals. The JSON body is pretty-printed taking multiple lines and should be compressed into a single line. The useless verbosity blows up the logs and makes it more difficult for sysops to browse the logs.
|
steveellis
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/OKAPI-1207
okapi-common' LoginClient and RefreshClient fail if user is blocked or password is wrong. It causes a log entry with stacktrace and multi-line JSON body.
The stacktrace is useless because it only shows Netty and Vert.x interals.
The JSON body is pretty-printed taking multiple lines and should be compressed into a single line.
The useless verbosity blows up the logs and makes it more difficult for sysops to browse the logs.