UIBULKED-388 Bulk edit - Scrollable element not keyboard accessible #423
Conversation
There was a problem hiding this comment.
Let's wait for feedback from @JohnC-80 before merging this; I see you pinged him for review here and in the comments on UIBULKED-388. It does feel like the fix should be implemented in STCOM if possible, so all apps benefit from it.
Hi @zburke, @JohnC-80 helped me with this approach so all should be good, I've just added him as reviewer for additional notification. |
There was a problem hiding this comment.
Yeah, reading through the documentation for no-noninteractive-tabindex makes it clear why this is the correct approach:
If you know that a particular element will be scrollable, you might want to add
tabindex="0"if your website supports browsers that don't make these containers keyboard-focusable.
Please include a link to documentation in the PR description. It wasn't clear to me why "section with empty message [should be] focusable", so the additional context that "technically, the empty-message pane could be scrollable, and scrollable elements should be focusable and can be made so with tabindex="0"".
# Conflicts: # CHANGELOG.md
|
SonarCloud Quality Gate failed.
|
Purpose
After this fix merged, section with empty message will be focusable
Refs: STCOM-1222
Docs: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/no-noninteractive-tabindex.md#case-shouldnt-i-add-a-tabindex-so-that-users-can-navigate-to-this-item
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.