Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-384 UI - Rendering holdings electronic access properties #425

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Dec 5, 2023

At the moment, Electroniс access is a string separated using the following delimeters: "|" for rows, and ";" - for columns. It's very difficult to read.
Therefore, it was decided to display a table in this column that displays all the information about Electronic Access in a convenient form. Refs: UIBULKED-384.

Was:

image

Now:

image

Copy link

github-actions bot commented Dec 5, 2023

Jest Unit Test Statistics

    1 files  ±0    27 suites  +1   2m 50s ⏱️ +5s
174 tests +3  173 ✔️ +3  1 💤 ±0  0 ±0 
177 runs  +3  176 ✔️ +3  1 💤 ±0  0 ±0 

Results for commit 5f4841d. ± Comparison against base commit dc8cdde.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 5f4841d. ± Comparison against base commit dc8cdde.

♻️ This comment has been updated with latest results.

@vashjs vashjs requested review from UladzislauKutarkin and a team December 6, 2023 12:34
@vashjs
Copy link
Contributor Author

vashjs commented Dec 8, 2023

@OleksandrHladchenko1 could you please review?

src/utils/mappers/mappers.js Show resolved Hide resolved
@@ -11,6 +11,9 @@ import {
} from '../../constants';

import { getMappedTableData, DATA_TYPES } from './mappers';
import {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@vashjs vashjs merged commit f1cffa0 into master Dec 8, 2023
5 checks passed
@vashjs vashjs deleted the UIBULKED-384 branch December 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants