[UICAL-269] Migrate from self-contained typings to stripes-types #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danetsao
approved these changes
Dec 21, 2023
|
zburke
added a commit
that referenced
this pull request
Dec 22, 2023
…pes (#506)" (#507) This reverts commit 011ce22 (UICAL-269/PR #506). platform automation builds fail with numerous typescript-related errors, e.g. ``` ERROR in /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/calendar/src/components/fields/ServicePointAssignmentField.tsx ./node_modules/@folio/calendar/src/components/fields/ServicePointAssignmentField.tsx 51:10-19 [tsl] ERROR in /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/calendar/src/components/fields/ServicePointAssignmentField.tsx(51,11) TS2769: No overload matches this call. Overload 1 of 2, '(props: MultiSelectionProps<ServicePoint> | Readonly<MultiSelectionProps<ServicePoint>>): MultiSelection<...>', gave the following error. Type '({ option, searchTerm, }: { option: ServicePoint; searchTerm: string | undefined; }) => React.JSX.Element' is not assignable to type '(option: ServicePoint, searchTerm: string) => ReactNode'. Types of parameters '__0' and 'option' are incompatible. Type 'ServicePoint' is missing the following properties from type '{ option: ServicePoint; searchTerm: string; }': option, searchTerm Overload 2 of 2, '(props: MultiSelectionProps<ServicePoint>, context: any): MultiSelection<ServicePoint, MultiSelectionProps<ServicePoint>>', gave the following error. Type '({ option, searchTerm, }: { option: ServicePoint; searchTerm: string | undefined; }) => React.JSX.Element' is not assignable to type '(option: ServicePoint, searchTerm: string) => ReactNode'. @ ./node_modules/@folio/calendar/src/forms/CalendarForm/CalendarForm.tsx 22:0-94 81:44-71 @ ./node_modules/@folio/calendar/src/views/CreateEditCalendarLayer.tsx 16:0-75 41:230-237 42:32-44 @ ./node_modules/@folio/calendar/src/views/AllCalendarView.tsx 13:0-64 86:44-67 96:44-67 @ ./node_modules/@folio/calendar/src/views/CalendarSettings.tsx 17:0-48 30:31-46 @ ./node_modules/@folio/calendar/src/index.tsx 13:0-48 16:35-43 @ ./node_modules/stripes-config.js ```
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira UICAL-269
Purpose
Initially, we developed our own typings for the Stripes framework, to be used internally by ui-calendar. This was great when we were the only TypeScript module in the FOLIO ecosystem, however, that is no longer the case, and it does not make sense for
ui-calendarto be the source of truth for Stripes typings.Approach
Types were moved to https://github.com/folio-org/stripes-types (over the past many months), where they can be contributed to and shared by all FOLIO developers.
Now that this central location exists, there's no reason for ui-calendar to contain the old types; in fact, they often caused conflicts when attempting to build a platform.
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondinglyN/A