Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explicit return types in ambiguous case #556

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

ncovercash
Copy link
Member

The typing ambiguity here between the different returns caused some build problems with newer eslint versions.

@folio-org folio-org deleted a comment from sonarqubecloud bot Feb 27, 2025
@folio-org folio-org deleted a comment from github-actions bot Feb 27, 2025
@folio-org folio-org deleted a comment from sonarqubecloud bot Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Jest Unit Test Results

  1 files  ± 0   73 suites  +6   8m 24s ⏱️ + 2m 28s
332 tests +24  331 ✅ +23  1 💤 +1  0 ❌ ±0 
359 runs  +26  358 ✅ +25  1 💤 +1  0 ❌ ±0 

Results for commit 16c3a88. ± Comparison against base commit 5af6f24.

♻️ This comment has been updated with latest results.

@ncovercash ncovercash merged commit af9349d into master Feb 27, 2025
15 checks passed
@ncovercash ncovercash deleted the typings-fix branch February 27, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants