UIEH-1394: Fix deleting and then saving custom embargo.

CHANGELOG.md

@@ -5,6 +5,10 @@
 * Remove Bigtest tests. (UIEH-1390)
 * Remove eslint deps that are already listed in eslint-config-stripes. (UIEH-1389)
 
+## [9.0.1] (IN PROGRESS)
+
+* Fix deleting and then saving custom embargo. (UIEH-1394)
+
 ## [9.0.0] (https://github.com/folio-org/ui-eholdings/tree/v9.0.0) (2023-10-13)
 
 * Custom labels | Remove a dashes below labels. (UIEH-1361)

src/components/resource/_fields/custom-embargo/custom-embargo-fields.js

@@ -176,7 +176,7 @@ export default class CustomEmbargoFields extends Component {
       initialValues,
     ];
 
-    return fields.value.length
+    return fields.value?.length
       ? this.renderInputs(...fieldsData)
       : this.renderAddButton(...fieldsData);
   }

src/components/resource/_fields/custom-embargo/custom-embargo.test.js

@@ -126,4 +126,19 @@ describe('Given CustomEmbargoFields', () => {
       expect(getByTestId('custom-embargo-value')).toBeDefined();
     });
   });
+
+  describe('when the user deleted the embargo period', () => {
+    it('should see the "Add custom embargo period" button', () => {
+      const { getByRole } = renderCustomEmbargoFields({
+        customEmbargoPeriod: [{ embargoUnit: 'Days', embargoValue: 33 }],
+      });
+
+      const deleteEmbargoBtn = getByRole('button', { name: 'ui-eholdings.resource.embargoPeriod.clear' });
+      fireEvent.click(deleteEmbargoBtn);
+
+      const addEmbargoBtn = getByRole('button', { name: 'ui-eholdings.resource.embargoPeriod.addCustom' });
+
+      expect(addEmbargoBtn).toBeDefined();
+    });
+  });
 });

src/routes/resource-edit-route/resource-edit-route.js

@@ -153,7 +153,7 @@ class ResourceEditRoute extends Component {
         url: customUrl,
         visibilityData: { isHidden: !isVisible },
         coverageStatement,
-        customEmbargoPeriod: customEmbargoPeriod[0] || defaultEmbargoPeriod,
+        customEmbargoPeriod: customEmbargoPeriod?.[0] || defaultEmbargoPeriod,
         proxy: { id: proxyId },
         accessTypeId: newAccessTypeId,
         userDefinedField1,

src/routes/resource-edit-route/resource-edit-route.test.js

@@ -331,4 +331,26 @@ describe('Given ResourceEditRoute', () => {
       expect(mockUpdateResource).toHaveBeenCalled();
     });
   });
+
+  describe('when user clicks on Save & close button', () => {
+    it('should call updateResource with default embargo period', () => {
+      const defaultEmbargoPeriod = { embargoValue: 0 };
+
+      const { getByRole } = renderResourceEditRoute({
+        model: {
+          ...model,
+          isSelected: true,
+        },
+      });
+
+      const deleteEmbargoBtn = getByRole('button', { name: 'ui-eholdings.resource.embargoPeriod.clear' });
+      fireEvent.click(deleteEmbargoBtn);
+
+      fireEvent.submit(getByRole('button', { name: 'stripes-components.saveAndClose' }));
+
+      expect(mockUpdateResource).toHaveBeenCalledWith(expect.objectContaining({
+        customEmbargoPeriod: defaultEmbargoPeriod,
+      }));
+    });
+  });
 });