Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIEH-1442: Do not run clearPackageTitles when loading package titles (follow-up PR). #1761

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jan 20, 2025

Purpose

  1. Display previous list items while loading new ones (follow-up PR).
  2. Preserve the height of the package title container while loading the new list items.

Issues

UIEH-1442

Approach

  1. Remove clear-related functionality. This is legacy code that is no longer relevant for the current implementation.
  2. Set a specific height for the package title container.

TODOS and Open Questions

Learning

Screenshots

2025-01-20_19h50_02.mp4

Copy link

github-actions bot commented Jan 20, 2025

Jest Unit Test Results

    1 files  ±0    195 suites  ±0   4m 50s ⏱️ +6s
1 107 tests ±0  1 104 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 115 runs  ±0  1 112 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 45d563f. ± Comparison against base commit 2a690fb.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Given PackageShowRoute when package search params change when changed param is not single and it is not "page" should handle clearPackageTitles ‑ Given PackageShowRoute when package search params change when changed param is not single and it is not "page" should handle clearPackageTitles
Given PackageShowRoute when package search params change when packages are being fetched should not clear old ones ‑ Given PackageShowRoute when package search params change when packages are being fetched should not clear old ones

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn changed the title UIEH-1442: Do not run clearPackageTitles when loading package titles (follow-up PR). UIEH-1442: Do not run clearPackageTitles when loading package titles (follow-up PR). Jan 20, 2025
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team January 20, 2025 13:16
@artem-blazhko artem-blazhko requested a review from a team January 20, 2025 16:59
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 1fb2872 into master Jan 22, 2025
16 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIEH-1442 branch January 22, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants