UIIN-2546/UIIN-2548/UIIN-2549/UIIN-2556/UIIN-2557 Number generator implementation #2408
+706
−16
feat: Holdings
Added call number generator button to Holdings form, tweaks to settings
commit 3592bab20d656d7eaa76e004c26bc7da5d878e3b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Please, cover this component with unit tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,34 @@ | ||
| import { useRef } from 'react'; | ||
|
|
||
| import { FormattedMessage } from 'react-intl'; | ||
| import { Field, useFormState } from 'react-final-form'; | ||
|
|
||
| import { | ||
| Accordion, | ||
| AccordionSet, | ||
| AccordionStatus, | ||
| Button, | ||
| Checkbox, | ||
| Col, | ||
| ExpandAllButton, | ||
| InfoPopover, | ||
| Label, | ||
| Layout, | ||
| MessageBanner, | ||
| RadioButton, | ||
| Row, | ||
| } from '@folio/stripes/components'; | ||
|
|
||
| import css from './NumberGeneratorOptions.css'; | ||
|
|
||
| const NumberGeneratorOptionsForm = () => { | ||
| const accordionStatusRef = useRef(); | ||
| const { values } = useFormState(); | ||
| const disableUseForBothFields = | ||
| (values?.accessionNumberGeneratorSettingItems ?? 'useTextField') === 'useTextField' || | ||
| (values?.callNumberGeneratorSettingItems ?? 'useTextField') === 'useTextField'; | ||
|
|
||
| const disableAccessionNumberAndCallNumberOffOptions = !!values?.useAccessionNumberForCallNumberItems; | ||
|
|
||
| return ( | ||
| <> | ||
| @@ -23,165 +41,229 @@ const NumberGeneratorOptionsForm = () => { | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| <AccordionStatus ref={accordionStatusRef}> | ||
| <Row end="xs"> | ||
| <Col xs> | ||
| <ExpandAllButton /> | ||
| </Col> | ||
| </Row> | ||
| <AccordionSet> | ||
| <Accordion | ||
| label={ | ||
| <h3> | ||
| <FormattedMessage id="ui-inventory.items" /> | ||
| </h3> | ||
| } | ||
| id="number-generator-options-items" | ||
| > | ||
| <Row> | ||
| <Col xs={12}> | ||
| <div className={css.marginBottomGutter}> | ||
| <Label> | ||
| <FormattedMessage id="ui-inventory.barcode" /> | ||
| </Label> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useTextFieldBarcodeIt" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useTextFieldForBarcode" />} | ||
| name="barcodeGeneratorSettingItems" | ||
| type="radio" | ||
| value="useTextField" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useBothBarcodeItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useBothForBarcode" />} | ||
| name="barcodeGeneratorSettingItems" | ||
| type="radio" | ||
| value="useBoth" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useGeneratorBarcodeItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useGeneratorForBarcode" />} | ||
| name="barcodeGeneratorSettingItems" | ||
| type="radio" | ||
| value="useGenerator" | ||
| /> | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| <Row> | ||
| <Col xs={12}> | ||
| <div className={css.marginBottomGutter}> | ||
| <Label> | ||
| <FormattedMessage id="ui-inventory.accessionNumber" /> | ||
| </Label> | ||
| <Field | ||
| component={RadioButton} | ||
| disabled={disableAccessionNumberAndCallNumberOffOptions} | ||
| id="useTextFieldAccessionNumberItems" | ||
| label={ | ||
| <div className={disableAccessionNumberAndCallNumberOffOptions ? css.greyLabel : null}> | ||
| <FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useTextFieldForAccessionNumber" /> | ||
| </div> | ||
| } | ||
| name="accessionNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useTextField" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useBothAccessionNumberItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useBothForAccessionNumber" />} | ||
| name="accessionNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useBoth" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useGeneratorAccessionNumberItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useGeneratorForAccessionNumber" />} | ||
| name="accessionNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useGenerator" | ||
| /> | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| <Row> | ||
| <Col xs={12}> | ||
| <div className={css.marginBottomGutter}> | ||
| <Label> | ||
| <FormattedMessage id="ui-inventory.callNumber" /> | ||
| </Label> | ||
| <Field | ||
| className={disableAccessionNumberAndCallNumberOffOptions ? css.greyLabel : null} | ||
| component={RadioButton} | ||
| disabled={disableAccessionNumberAndCallNumberOffOptions} | ||
| id="useTextFieldCallNumberItems" | ||
| label={ | ||
| <div className={disableAccessionNumberAndCallNumberOffOptions ? css.greyLabel : null}> | ||
| <FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useTextFieldForCallNumber" /> | ||
| </div> | ||
| } | ||
| name="callNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useTextField" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useBothCallNumberItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useBothForCallNumber" />} | ||
| name="callNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useBoth" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useGeneratorCallNumberItems" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useGeneratorForCallNumber" />} | ||
| name="callNumberGeneratorSettingItems" | ||
| type="radio" | ||
| value="useGenerator" | ||
| /> | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| <Row> | ||
| <Col xs={12}> | ||
| <div className={css.marginBottomGutter}> | ||
| <Field | ||
| disabled={disableUseForBothFields} | ||
| component={Checkbox} | ||
| label={ | ||
| <> | ||
| <div className={disableUseForBothFields ? css.greyLabel : null}> | ||
| <FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useAccessionNumberForCallNumber" /> | ||
| </div> | ||
| <InfoPopover | ||
| content={ | ||
| <Layout className="display-flex flex-direction-column flex-align-items-center flex-wrap--wrap"> | ||
| <Layout className="padding-bottom-gutter display-flex flex-direction-column flex-align-items-center"> | ||
| <FormattedMessage | ||
| id="ui-inventory.settings.numberGeneratorOptions.useAccessionNumberForCallNumberInfo" | ||
| values={{ | ||
| linebreak: <br /> | ||
| }} | ||
| /> | ||
| </Layout> | ||
| <Layout className="display-flex flex-direction-column flex-align-items-center"> | ||
| <Button | ||
| allowAnchorClick | ||
| buttonStyle="primary" | ||
| href="https://wiki.folio.org/display/FOLIOtips/Number+generator" | ||
| marginBottom0 | ||
| > | ||
| <FormattedMessage id="ui-inventory.settings.learnMore" /> | ||
| </Button> | ||
| </Layout> | ||
| </Layout> | ||
| } | ||
| iconSize="medium" | ||
| /> | ||
| </> | ||
| } | ||
| name="useAccessionNumberForCallNumberItems" | ||
| type="checkbox" | ||
| /> | ||
| {disableUseForBothFields && | ||
| <MessageBanner type="warning"> | ||
| <FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useAccessionNumberForCallNumberWarning" /> | ||
| </MessageBanner> | ||
| } | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| </Accordion> | ||
| <Accordion | ||
| label={ | ||
| <h3> | ||
| <FormattedMessage id="ui-inventory.holdings" /> | ||
| </h3> | ||
| } | ||
| id="number-generator-options-holdings" | ||
| > | ||
| <Row> | ||
| <Col xs={12}> | ||
| <div className={css.marginBottomGutter}> | ||
| <Label> | ||
| <FormattedMessage id="ui-inventory.callNumber" /> | ||
| </Label> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useTextFieldCallNumberHoldings" | ||
| label={ | ||
| <div className={disableAccessionNumberAndCallNumberOffOptions ? css.greyLabel : null}> | ||
| <FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useTextFieldForCallNumber" /> | ||
| </div> | ||
| } | ||
| name="callNumberGeneratorSettingHoldings" | ||
| type="radio" | ||
| value="useTextField" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useBothCallNumberHoldings" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useBothForCallNumber" />} | ||
| name="callNumberGeneratorSettingHoldings" | ||
| type="radio" | ||
| value="useBoth" | ||
| /> | ||
| <Field | ||
| component={RadioButton} | ||
| id="useGeneratorCallNumberHoldings" | ||
| label={<FormattedMessage id="ui-inventory.settings.numberGeneratorOptions.useGeneratorForCallNumber" />} | ||
| name="callNumberGeneratorSettingHoldings" | ||
| type="radio" | ||
| value="useGenerator" | ||
| /> | ||
| </div> | ||
| </Col> | ||
| </Row> | ||
| </Accordion> | ||
| </AccordionSet> | ||
| </AccordionStatus> | ||
| </> | ||
| ); | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move
number_generatorto constants, please, I see this is used in several places.