*DO NOT MERGE* UIIN-3162 *BREAKING* Use browse 1.5 interface that provides new Call Number Browse endpoints.
#2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all Number Browse endpoints.
zburke
approved these changes
Dec 18, 2024
artem-blazhko
approved these changes
Dec 19, 2024
BogdanDenis
changed the title
browse 1.5 interface that provides new Call Number Browse endpoints.browse 1.5 interface that provides new Call Number Browse endpoints.
mariia-aloshyna
approved these changes
Dec 19, 2024
BogdanDenis
force-pushed
the
UIIN-3162
branch
from
de49231 to
70e2943
Compare
| @@ -16,7 +16,7 @@ const useSearchForShadowInstanceTenants = ({ instanceId } = {}) => { | |||
|
|
|||
| const { isLoading, data = {} } = useQuery({ | |||
| queryKey: [namespace, consortium, instanceId], | |||
| queryFn: () => ky.get('search/instances/facets', | |||
| queryFn: () => ky.get('search/call-numbers/facets', | |||
There was a problem hiding this comment.
Is this necessary for useSearchForShadowInstanceTenants?
Comment on lines
+120
to
+122
| qindex: queryIndexes.ITEM_NORMALIZED_CALL_NUMBERS, | ||
| query: fullCallNumber, | ||
| segment: segments.items, |
There was a problem hiding this comment.
This is repeating, let's move it to a variable, like classificationOption.
Comment on lines
+141
to
+144
| const fullCallNumber = getFullCallNumber(r); | ||
|
|
||
| if (r?.totalRecords) { | ||
| return getTargetRecord(fullCallNumber, r, ...commonTargetRecordArgs); |
There was a problem hiding this comment.
Should <MissedMatchItem query={r.fullCallNumber} /> also be changed?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING Use
browse1.5interface that provides new Call Number Browse endpoints.Issues
UIIN-3162