Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component and fix accordion states between instances #2716

Merged
merged 7 commits into from
Jan 28, 2025
Merged

UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component and fix accordion states between instances #2716

merged 7 commits into from
Jan 28, 2025

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented Jan 20, 2025 •
edited
Loading

Purpose

  • Lots of re-renders of ConsortialHoldings cause twitching when Instance details page is open.

Approach

  • Removed from key prop from ConsortialHoldings.
  • Fixed behavior of consortial holding accordions. Now they remember their state correctly.

Refs

UIIN-3160

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   15m 27s ⏱️ +44s
1 025 tests ±0  1 023 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 032 runs  ±0  1 030 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 747ec2c. ± Comparison against base commit ca8b571.

♻️ This comment has been updated with latest results.

@artem-blazhko artem-blazhko requested a review from a team January 20, 2025 17:00
@OleksandrHladchenko1 OleksandrHladchenko1 changed the title UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component and fix accordion states between instances Jan 28, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 2f80568 into master Jan 28, 2025
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-3160 branch January 28, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-blazhko artem-blazhko artem-blazhko approved these changes

@Dmitriy-Litvinenko Dmitriy-Litvinenko Dmitriy-Litvinenko approved these changes

@mariia-aloshyna mariia-aloshyna Awaiting requested review from mariia-aloshyna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @Dmitriy-Litvinenko @artem-blazhko