Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3174: Holdings: Display all versions in View history second pane #2761

Merged
merged 14 commits into from
Mar 5, 2025
Merged

UIIN-3174: Holdings: Display all versions in View history second pane #2761

merged 14 commits into from
Mar 5, 2025

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Render View history pane for Inventory holdings.

Approach

  • Use AuditLogPane component to render View history
  • Create fieldLabelsMap and fieldFormatter for holding changed fields

Refs

UIIN-3174

Screenshots

image
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Jest Unit Test Results

    1 files  ± 0    268 suites  +2   12m 23s ⏱️ +14s
1 135 tests +13  1 133 ✅ +13  2 💤 ±0  0 ❌ ±0 
1 142 runs  +13  1 140 ✅ +13  2 💤 ±0  0 ❌ ±0 

Results for commit 8d87597. ± Comparison against base commit 2dba643.

♻️ This comment has been updated with latest results.

artem-blazhko
artem-blazhko approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@artem-blazhko artem-blazhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you increase code coverage to required 80%?

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team February 26, 2025 20:27
@folio-org folio-org deleted a comment from sonarqubecloud bot Mar 5, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mariia-aloshyna mariia-aloshyna merged commit f19ea5c into master Mar 5, 2025
15 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-3174 branch March 5, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-blazhko artem-blazhko artem-blazhko approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @artem-blazhko @mariia-aloshyna