MODSER-57: Generate pieces deprecation handling #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conditional when passing genrated pieces to pieces list, older versions of the backend fetched an array of pieces, whereas the new endpoint returns a predicted piece set, this conditional sorts if the enpoint is either an object or an array
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
|
Pieces within the pieces preview modal fetched from the endpoint are now currently sorted, fix |
Moved sort pieces function to utility class and implemeted into pieces preview modal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditional when passing genrated pieces to pieces list, older versions of the backend fetched an array of pieces, whereas the new endpoint returns a predicted piece set, this conditional sorts if the enpoint is either an object or an array
Merge after mod-serials-management PR #117