feat(docs): skip docs task for read-only directories #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sei40kr
commented
Jan 21, 2025
| @@ -87,7 +87,7 @@ M.build = { | |||
|
|
|||
| M.docs = { | |||
| skip = function(plugin) | |||
| return not plugin._.is_local and not plugin._.dirty | |||
| return not plugin._.is_local and not plugin._.dirty or not vim.uv.fs_access(plugin.dir, "W") | |||
There was a problem hiding this comment.
If the plugin is not local, it is likely not read-only, in which case it may save IO costs by not checking permissions.
Suggested change
| return not plugin._.is_local and not plugin._.dirty or not vim.uv.fs_access(plugin.dir, "W") | |
| return not plugin._.is_local and not plugin._.dirty or plugin._.is_local and not vim.uv.fs_access(plugin.dir, "W") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip
docstask for plugins in read-only directories to avoid errors.This assumes a case where, for example, lazy.nvim references a plugin in the Nix store.